perf(reader): cache OpenDAL Operators#2177
Draft
mbutrovich wants to merge 1 commit intoapache:mainfrom
Draft
Conversation
mbutrovich
changed the title
mbutrovich
changed the title
Contributor
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
Collaborator
Author
|
Still thinking about this one and will revisit with the Storage trait work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft/POC for discussion, particularly @Xuanwo and @CTTY.
Which issue does this PR close?
What changes are included in this PR?
operator_cache: Arc<Mutex<HashMap<String, Operator>>>to S3, Gcs, Oss, and Azdls variants ofOpenDalStorageget_or_create_operator()helper that checks the cache by bucket/container name before building a new operatorcreate_operator()now caches operators per bucket for S3/GCS/OSS and per filesystem for AzdlsRetryLayeris applied once when an operator is created and cached, rather than on every callAre these changes tested?
Existing tests.